Reviewing pipeline releases
Pipeline release reviews ensure that pipelines meet nf-core standards before they reach the community. When you review a pipeline release pull request, you examine the submission and provide constructive feedback before maintainers merge the changes into the nf-core repository.
Pipeline release PRs vary widely in their contents, making it harder to provide strict universal criteria compared to reviewing components. Your role as a reviewer is to check for adherence to the central principles of nf-core: reproducibility, excellent reporting, documentation, and template compliance.
Use the pipeline release review checklist for a quick reference whilst reviewing.
Before you start
Pipeline release reviews can feel overwhelming, particularly when doing one for the first time. Remember that you don’t need to be an expert in the scientific domain to provide valuable feedback on code quality, documentation, and adherence to nf-core standards.
Focus on the general nf-core pipeline guidelines rather than the scientific accuracy of the analysis. Your perspective helps catch issues that developers might have missed.
Review nf-core principles
Start by verifying that the pipeline meets the general nf-core guidelines. Check that the pipeline:
You can find the complete set of pipeline guidelines in the pipeline overview.
Review local code and modules
Local modules and scripts require careful attention because they don’t benefit from the community review process that nf-core/modules receives.
Local scripts
Check that scripts in the bin/ directory include:
Local modules
Verify that all local modules in modules/local/ include:
-
Note
If a module could be useful across multiple pipelines, suggest moving it to the shared repository for broader community benefit.
Review documentation
Documentation makes pipelines accessible to the community. Focus your review on these key areas:
Documentation location
Verify that all documentation:
Core documentation files
Check that usage.md, output.md, and nextflow_schema.json provide comprehensive information:
Changelog and versioning
Ensure the CHANGELOG follows three-point semantic versioning (for example, 2.1.0 rather than 2.1). Check that:
Citations
Review CITATIONS.md for:
Proofreading
Proofread documentation for:
-
Note
Well-written documentation helps users get started quickly and reduces support requests.
Review code quality
General code review
Assess the code for:
Avoid requiring major code optimisation unless it affects functionality. Small optimisation suggestions are welcome, but large refactoring should have happened during development PRs rather than at release time.
Parameter conventions
Check that parameters follow nf-core conventions:
Manifest
Verify that the manifest:
What you don’t need to review
To keep reviews focused and efficient, you don’t need to:
-
Review code from nf-core/modules (these modules have their own review process)
-
Comment on scientific accuracy unless you’re familiar with the topic
-
Require major code optimisation at the release stage
NoteYou can suggest small code optimisation.
However, larger code optimisation shouldn’t necessarily be required for release. :::
Remember that your review helps maintain quality across the nf-core ecosystem. Thank you for contributing your time to make nf-core pipelines better for everyone.